Extended messages cannot have required fields (must be optional). #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roland Haeder <[email protected]>
|
Thanks. this might be due to using a new protocol buffer version. What version are you using ? |
|
$ protoc --version Is my change working with older versions? Then, I think, it is save to merge. :-) |
…rriant. Signed-off-by: Roland Haeder <[email protected]>
- header('Location: bla-blub'); does *NOT* abort the script, *ALWAYS* use an explicit exit() call!
- Check for $_SERVER array elements, not all browsers may send it causing E_NOTICE (bad code style)
- Converted double-quotes to single-quotes
- if() and else conditions are now in one line + curly braces are always explicitly set
- Other small cleanups
Signed-off-by: Roland Haeder <[email protected]>
Signed-off-by: Roland Haeder <[email protected]>
…ification it *MUST* be prefixed with 'X-'. Signed-off-by: Roland Haeder <[email protected]>
Signed-off-by: Roland Haeder <[email protected]>
Signed-off-by: Roland Haeder <[email protected]>
Signed-off-by: Roland Haeder <[email protected]>
Signed-off-by: Roland Haeder <[email protected]>
Signed-off-by: Roland Haeder <[email protected]>
Signed-off-by: Roland Haeder <[email protected]>
Error: 1 (Out of memory) in plugin websearch-api-compat caught in top-level handler This only happens on my LAN instance, not the one at https://seeks.mxchange.org/search.php ... Signed-off-by: Roland Haeder <[email protected]>
Signed-off-by: Roland Haeder <[email protected]>
Signed-off-by: Roland Haeder <[email protected]>
Signed-off-by: Roland Haeder <[email protected]>
…ines added. Signed-off-by: Roland Haeder <[email protected]>
Signed-off-by: Roland Haeder <[email protected]>
|
:-( All commits end up here in one merge request ... They should have made this notice bigger. |
|
Thanks, I'll take time to review this. |
http://tools.ietf.org/html/rfc6648 Signed-off-by: Roland Haeder <[email protected]>
|
My apologies I was taken elsewhere and missed this PR. Is this still relevant ? Are you using Seeks ? |
|
I am using Seeks every day. I am willing to test whatever there is to test in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an error when I use the proto file db_query_record_msg.proto:
db_query_record_msg.proto:36:11: Message extensions cannot have required fields.
/home/quix0r/git/seeks/src/plugins/query_capture/Makefile:850: recipe for target 'db_query_record_msg.pb.cc' failed
make: *** [db_query_record_msg.pb.cc] Error 1
This small change fixes it.