Fix some missing fields for ClassAccessorProperty and related defs
#891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now better aligned with the Babel version: https://github.com/babel/babel/blob/362451b76439ea17308c392d8c782135de0823de/packages/babel-types/src/definitions/core.ts#L2265-L2344 Should address benjamn/recast#1232 (comment)
|
@benjamn I'm using that approach in https://github.com/codemodsquad/astx/blob/main/src/babel/babelAstTypes.ts and it seems to work well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now better aligned with the Babel version.
This should address benjamn/recast#1232 (comment), though I am beginning to see the value of @jedwards1211's proposal in #823 to handle Babel types using a more programmatic approach…