Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving benjamn/recast#1283 would be difficult because
it imports ast-types everywhere, and I would have to replace those references
with passing an ast-types fork as new function parameters all over the place.
This is the pragmatic solution, it would allow me to just replace all of the
ast-types exports with my own fork built from
@babel/types
(see#823). So anywhere that imports
them would get my definitions that are up-to-date with babel.
Building defs from
@babel/types
or other parsers' metadata is the onlysustainable option for the community to have a reliable codemod system built on recast.