Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include django-extensions as required installations #256

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

simkimsia
Copy link
Contributor

Because autoslugfield requires django-extensions as indicated here https://github.com/bennylope/django-organizations/blob/2dd044956cf03dad9c8c4954ba325d2769fe3643/docs/getting_started.rst#auto-slug-field

and the minimum version is taken from

django-extensions>=2.0.8

@bennylope bennylope merged commit c92c7a1 into bennylope:master Nov 21, 2023
4 checks passed
@bennylope
Copy link
Owner

I'm not overly fond of including this by default, since you can use the package as a "plain" library without needing to install the Django app (thus not needing this dependency).

However the alternatives are (1) status quo or (2) declare named optional dependencies in the setup files... this is probably the simplest way forward. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants