Python 3 style cleanup (part 2) #3280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git ls-files -z "tests/requests/**.py" | xargs -0 sed -i -e '/^cfg = Config()$/d' -e '/^from gunicorn.config import Config$/d' --
git ls-files -z "tests/requests/**.py" | xargs -0 sed -z -i -e "s/''"'/""/g' -e 's/"\n\+}/",\n}/g' -e 's/)\n\+ \]/),\n ]/g' --
git ls-files -z "tests/requests/**.py" | xargs -0 python3 -m black --skip-string-normalization --line-length=120 --target-version=py37 --
git restore tests/requests/valid/{001..027}.py tests/requests/valid/{025_line,padding_01,100}.py tests/requests/invalid/{002,003,chunked_*,018,version_01,version_02,003c}.py tests/requests/invalid/{006..009}.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup, follow-up to #3189 - There is a change of config default in here, but for our workers that only impacts who sees the warning about the ignored setting. Rest is intended to be no-op.
Unfinished consideration:
InvalidChunkSize(and most of the meaning ofNoMoreDataandChunkMissingTerminator, though that needs to be split first) subclassing IOError is just wrong, replacing with OSError does not fix that. Input reading worked perfectly fine, its the content of that input that our parser found issues with. Maybe some of it could re-use the built-in EOFError, but only while avoiding confusing unexpected SSL tunnel shutdown with previously announced end of input.Suggested merge order: merge last