Use original arguments on arbiter re-exec, and tell systemd so exiting old master does not terminate service #3285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajod
commented
Aug 27, 2024
| self.log.info("Master exited before promotion.") | ||
| # let systemd know we are (back) in control | ||
| systemd.sd_notify("READY=1\nMAINPID=%d\nSTATUS=Gunicorn arbiter re-exec aborted\n" % (os.getpid(), ), self.log) | ||
| continue |
There was a problem hiding this comment.
Pylint hates useless indents. Deliberately not fixing this until #3148 is merged, otherwise merging is a pain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
missing: document difference between behavior of
< 3.10and Python>= 3.10missing: document
Type=notify-reload(systemd>= v253)missing: Compatibility of systemd with zero downtime reloads with SIGUSR2 #2856 -- automatically shutdown old master after handling USR2 re-exec while systemd integration is active (because that is what you expect when you run
systemctl reload gunicorn)Fixes: module invocation breaks USR2 upgrading, as modified argv results in modified path #3281
Fixes: more status to systemd #1948