Deprecate GoodJob::Job#recent_error (#1526)

* Deprecate GoodJob::Job#recent_error * Fix linter
bensheldon · Oct 23, 2024 · 1cf9b07 · 1cf9b07
1 parent 839c037
commit 1cf9b07
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/app/models/good_job/job.rb b/app/models/good_job/job.rb
@@ -390,7 +390,12 @@ def self.format_error(error)
     # If the job has been retried, the error will be fetched from the previous {Execution} record.
     # @return [String]
     def recent_error
-      error || executions[-2]&.error
+      GoodJob.deprecator.warn(<<~DEPRECATION)
+        The `GoodJob::Job#recent_error` method is deprecated and will be removed in the next major release.
+
+        Replace usage of GoodJob::Job#recent_error with `GoodJob::Job#error`.
+      DEPRECATION
+      error
     end
 
     # Errors for the job to be displayed in the Dashboard.