Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new migrations to work with strong_migrations #1199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dixpac
Copy link
Contributor

@dixpac dixpac commented Dec 25, 2023

I needed to fix new migrations in order for strong_migrations to let them pass.

Don't think there was anything wrong with the original approach, I think it is more issue on the strong_migrations side, but still there is no reason users should do this manually.

I needed to fix new migrations in order for `strong_migrations` to let
them pass.

Don't think there was anything wrong with orginal approach, I think it
is more issue on the `strong_migrations` side, but still there is no
reason users should do this manually.
@bensheldon
Copy link
Owner

I think this looks good. Any ideas for how to make it fully reversible? (I realize it wasn't reversible before)

@bensheldon
Copy link
Owner

Looking through this in the fullness of time, I notice:

  • The migrations aren't reversible.
  • They're in conflict now with some Rubocop rules. Like breaking out the change_table into individual column changes now conflicts with Rubocop suggesting change_table bulk: true. It looks like strong_migrations isn't currently compatible with change_table; bummer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Inbox
Development

Successfully merging this pull request may close these issues.

2 participants