Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use svg use for svg icons #1428

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Use svg use for svg icons #1428

merged 3 commits into from
Jul 18, 2024

Commits on Jul 16, 2024

  1. Scope assets by version through a path element 

    `<use href>` can't make use of query parameters through the normal means
    @Earlopain
    Earlopain committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a9a704b View commit details
    Browse the repository at this point in the history

  2. Use html use elements for svg icons 

    You can imagine this as a sort of spritemap if you will.
Icons can be referenced by id and inserted into an `svg` element with `use`.

On the jobs index page, size is reduced from 305kb to 237kb. Quite nice
    @Earlopain
    Earlopain committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    897915f View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Fix dash_circle naming

    @bensheldon
    bensheldon committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    8b9cb2d View commit details
    Browse the repository at this point in the history