Refactor inline adapter to enable deferred execution after enqueue to allow batch-callbacks to use transaction-based advisory lock #1433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not quite sure whether the "juice is worth the squeeze" here, but it feels like the more correct thing to do.
Eventually, GoodJob will move to using a combination of row-level locking (to execute jobs) and transaction-level advisory locks (for control/synchronization). To use transaction-level advisory locks (instead of the current connection-based advisory locks), the locks have to be wrapped in a transaction. I would prefer jobs not execute within a transaction, but this presents a problem for Inline Execution mode in places where it's necessary to take a lock, and enqueue a job. Though this is (right now, maybe always) just a problem for the batch-callback job enqueueing. Which means, this is really a bunch of effort solely so that: