Clean up appraisals, add rails 8, use postgres 17 #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need for special handling anymore, they all work with the latest version
|
@bensheldon what do you think about using a more elaborate matrix for this? Many versions run in the same job and properly parallelizing would give a nice speed boost and better insight when something fails |
With the new appraisal, this can now be too low
|
@Earlopain definitely has been on my mind. I think the simplest would be to replace the appraisal command with a matrix using Also, I've been thinking of removing Appraisal entirely and manually authoring the gemfiles/ because there isn't a lot of them and they could be a lot cleaner/simpler. |
|
Yeah, I've been thinking about dropping appraisal for doing this as well. Cool that you're already on board with that (: I'll do that in a separate PR. |
Earlopain
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think specifying the two dependencies explicitly is needed anymore. All versions should support the latest variant. Let's see.