Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: authorized Katsu endpoints + slightly auth-aware Beacon #258

Merged
merged 30 commits into from
Sep 16, 2024

Conversation

davidlougheed
Copy link
Member

No description provided.

@davidlougheed davidlougheed changed the title [WIP] Authorized Katsu endpoints [WIP] feat: authorized Katsu endpoints Aug 14, 2024
@davidlougheed davidlougheed changed the title [WIP] feat: authorized Katsu endpoints [WIP] feat!: authorized Katsu endpoints Aug 14, 2024
# Conflicts:
#	py_bentoctl/auth_helper.py
@v-rocheleau
Copy link
Contributor

The migration guide will need to include a section on how to add a public grant for bento-public requests affected.

@davidlougheed davidlougheed changed the title [WIP] feat!: authorized Katsu endpoints feat!: authorized Katsu endpoints Sep 9, 2024
@davidlougheed davidlougheed marked this pull request as ready for review September 9, 2024 19:43
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

v-rocheleau

This comment was marked as duplicate.

@davidlougheed davidlougheed changed the title feat!: authorized Katsu endpoints feat!: authorized Katsu endpoints + slightly auth-aware Beacon Sep 12, 2024
@davidlougheed
Copy link
Member Author

@v-rocheleau re-requesting review, since I added more to docs + the new Beacon code needs a bit of testing.

Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small docs stuff, otherwise lgtm

docs/installation.md Outdated Show resolved Hide resolved
docs/migrating_to_17.md Show resolved Hide resolved
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidlougheed davidlougheed merged commit 14028d0 into releases/v17 Sep 16, 2024
2 checks passed
@davidlougheed davidlougheed deleted the feat/v17/katsu-auth-v2 branch September 16, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants