Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beacon network #259

Merged
merged 14 commits into from
Sep 17, 2024
Merged

Add beacon network #259

merged 14 commits into from
Sep 17, 2024

Conversation

gsfk
Copy link
Member

@gsfk gsfk commented Aug 15, 2024

Add handling for beacon network. Handled as extra beacon configuration, no new containers. Accompanies beacon pr #93., bento_public pr #165.

TODO:

  • add network config file
  • update bentoctl beacon methods
  • add feature switch for network
  • update docs

etc/bento_deploy.env Show resolved Hide resolved
@gsfk gsfk marked this pull request as ready for review September 17, 2024 14:31
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: a documentation request; otherwise lgtm

@@ -158,6 +158,14 @@ If using Beacon, first copy the configuration file:
Then update any config values as needed at `lib/beacon/config/beacon_config.json`
and `lib/beacon/config/beacon_cohort.json`.

If using the beacon network, copy the configuration file:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capital B for beacon for consistency

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(╯°□°)╯︵ ┻━┻

```

and update values at `lib/beacon/config/beacon_network_config.json`.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can a note about this be added to the v17 migration guide? Similar to here, basically

@@ -84,6 +84,21 @@ bento_authz public-data-access counts
```


## 5. Optionally, add Beacon network

To host a network of beacons, with a corresponding UI in bento_public, first copy the config file:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either Bento Public or bento_public with code ticks around it

```bash
BENTO_BEACON_NETWORK_ENABLED='true'
```

## 5. Start Bento
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this 6

Copy link
Member Author

@gsfk gsfk Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're so closely tied I didn't see the point separating them, especially as optional steps.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even still, I don't think it makes sense to have two step 5s, with one of them being optional and the other being required (and coming after the first step 5)

Copy link
Member Author

@gsfk gsfk Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, I was thinking of the env step as optional also, but I guess should be thrown in regardless

Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gsfk gsfk merged commit 7336b00 into releases/v17 Sep 17, 2024
2 checks passed
@gsfk gsfk mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants