Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grafana oauth email #260

Merged
merged 2 commits into from
Aug 20, 2024
Merged

fix: grafana oauth email #260

merged 2 commits into from
Aug 20, 2024

Conversation

v-rocheleau
Copy link
Contributor

Allows Keycloak users with no email to login to Grafana.

grafana/grafana#13549

@davidlougheed davidlougheed changed the base branch from main to releases/v17 August 19, 2024 18:46
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - maybe worth adding a comment above explaining why we hack in .sub as the email attr

@v-rocheleau v-rocheleau merged commit 080eaf9 into releases/v17 Aug 20, 2024
2 checks passed
@v-rocheleau v-rocheleau deleted the fix/grafana_oauth_email branch August 20, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants