Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove adminer from local compose file #267

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

v-rocheleau
Copy link
Contributor

@v-rocheleau v-rocheleau commented Sep 20, 2024

Was causing bentoctl to create 2 adminer containers in dev mode on some docker compose versions, leading to a port conflict.
Should not have been there to begin with, since the local compose is to mount code repositories for local dev.

Was causing bentoctl to create 2 adminer containers in dev mode, leading to a port conflict.
Should not have been there to begin with, since the local compose is to mount code repositories for local dev.
Copy link
Member

@davidlougheed davidlougheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh... that's what it was. lgtm

@v-rocheleau v-rocheleau merged commit 8959f7f into releases/v17 Sep 20, 2024
2 checks passed
@v-rocheleau v-rocheleau deleted the fix/adminer branch September 20, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants