Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17] Fixes/beacon wait for auth #274

Merged
merged 1 commit into from
Oct 4, 2024
Merged

[17] Fixes/beacon wait for auth #274

merged 1 commit into from
Oct 4, 2024

Conversation

gsfk
Copy link
Member

@gsfk gsfk commented Oct 3, 2024

  • don't launch beacon container until auth is ready
  • beacon network init is done at app start, so requires auth to be up

@gsfk gsfk changed the base branch from main to releases/v17 October 3, 2024 19:32
@gsfk gsfk changed the title Fixes/beacon wait for auth [17] Fixes/beacon wait for auth Oct 3, 2024
@gsfk gsfk requested a review from v-rocheleau October 3, 2024 19:33
@gsfk gsfk mentioned this pull request Oct 3, 2024
Merged
v-rocheleau
v-rocheleau approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gsfk gsfk merged commit 87b0d36 into releases/v17 Oct 4, 2024
2 checks passed
@gsfk gsfk deleted the fixes/beacon-wait-for-auth branch October 4, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-rocheleau v-rocheleau v-rocheleau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsfk @v-rocheleau