fixed missing fields

bento-platform · Nov 14, 2022 · 11f7c70 · 11f7c70
1 parent 84c56c5
commit 11f7c70
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/js/components/Overview/charts/BentoBarChart.js b/src/js/components/Overview/charts/BentoBarChart.js
@@ -20,6 +20,8 @@ const TICK_MARGIN = 5;
 const BentoBarChart = ({ title, data, units, height }) => {
   const { t } = useTranslation();
 
+  // remove "missing" field if zero
+  data = data.filter((e) => !(e.x === 'missing'));
   data = data.map((d) => ({ ...d, x: t(d.x) }));
 
   const titleStyle = {
@@ -45,9 +47,6 @@ const BentoBarChart = ({ title, data, units, height }) => {
 
   const totalCount = data.reduce((sum, e) => sum + e.y, 0);
 
-  // remove "missing" field if zero
-  data = data.filter((e) => !(e.x === 'missing'));
-
   return (
     <div style={wrapperStyle}>
       <div style={titleStyle}>{title}</div>

diff --git a/src/js/components/Overview/charts/BentoPie.js b/src/js/components/Overview/charts/BentoPie.js
@@ -41,6 +41,8 @@ function BentoPie({ data, height }) {
 
   // Changing immutable data to mutable data
   data = [...data];
+  // remove "missing" field if zero
+  data = data.filter((e) => !(e.x === 'missing'));
 
   // combining sections with less than OTHER_THRESHOLD
   const sum = data.reduce((acc, e) => acc + e.y, 0);