Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schemas): remove enum from assembly ID prop #59

Merged
merged 3 commits into from
May 8, 2024
Merged

fix(schemas): remove enum from assembly ID prop #59

merged 3 commits into from
May 8, 2024

Conversation

davidlougheed
Copy link
Member

No description provided.

@davidlougheed davidlougheed requested a review from gsfk May 8, 2024 14:05
gsfk
gsfk approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great.

The rest of the schema could probably use some refreshing (for example we allow searching REFERENCE as a genome even when vcfs are ingested with "filter out references") but this can be done later.

@davidlougheed davidlougheed merged commit 2d6b076 into master May 8, 2024
3 checks passed
@davidlougheed davidlougheed deleted the fix/search-assembly-enum branch May 8, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsfk gsfk gsfk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidlougheed @gsfk