Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add a global --context #4059

Merged
merged 9 commits into from
Jul 20, 2023
Merged

feat(cli): add a global --context #4059

merged 9 commits into from
Jul 20, 2023

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented Jul 18, 2023

Signed-off-by: Aaron [email protected]

What does this PR address?

Fixes #(issue)

Before submitting:

@aarnphm aarnphm requested a review from a team as a code owner July 18, 2023 15:12
@aarnphm aarnphm requested review from larme and removed request for a team July 18, 2023 15:12
@aarnphm aarnphm changed the title feat(cli): add --cloud-context for --push feat(cli): add --context for --push Jul 18, 2023
@github-actions
Copy link

github-actions bot commented Jul 20, 2023

Code Coverage

Package Statements
bentoml 69.03% (10637 / 15408)
Summary 69.03% (10637 / 15408)

@aarnphm aarnphm force-pushed the cli/--push-context branch 2 times, most recently from 5c40f84 to 2d1c459 Compare July 20, 2023 16:55
@aarnphm aarnphm requested a review from sauyon July 20, 2023 16:57
@aarnphm aarnphm changed the title feat(cli): add --context for --push feat(cli): add a global --context Jul 20, 2023
src/bentoml_cli/cloud.py Outdated Show resolved Hide resolved
src/bentoml_cli/cloud.py Outdated Show resolved Hide resolved
Signed-off-by: Aaron <[email protected]>
it is no longer Yatai specific anymore

Signed-off-by: Aaron <[email protected]>
@aarnphm aarnphm requested a review from sauyon July 20, 2023 19:34
Copy link
Contributor

@sauyon sauyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aarnphm aarnphm merged commit 05d82e4 into main Jul 20, 2023
40 of 41 checks passed
@aarnphm aarnphm deleted the cli/--push-context branch July 20, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants