Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: add time-series models with statsmodels #4979

Closed
wants to merge 17 commits into from

Conversation

jsamantaucd
Copy link

@jsamantaucd jsamantaucd commented Sep 18, 2024

Feature request
I have implemented and tested a feature that trains a time series model - ARIMA and serves it using BentoML's custom runner to make predictions.

Motivation
I believe it would be a nice guide to someone exploring time series models with custom runner implementation for models like ARIMA.

Others:
This feature was tested on Bentoml v1.2.16

@jsamantaucd jsamantaucd requested a review from a team as a code owner September 18, 2024 10:50
@jsamantaucd jsamantaucd requested review from frostming and removed request for a team September 18, 2024 10:50
@jsamantaucd
Copy link
Author

Hi @xianml, as per your suggestion I have created the same arima model example using bentoml >=1.2, please help to review. Regards!

@jsamantaucd jsamantaucd changed the title Arima custom runner feature: add example for time series models like ARIMA using BentoML Sep 18, 2024
@aarnphm aarnphm changed the title feature: add example for time series models like ARIMA using BentoML example: add time-series models with statsmodels Sep 18, 2024
Comment on lines +48 to +52
saved_model = bentoml.picklable_model.save_model(
"arima_forecast_model",
model,
signatures={"predict": {"batchable": True}},
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recommended API here is using bentoml.models.create with our latest API. https://docs.bentoml.org/en/latest/guides/model-store.html

@frostming
Copy link
Contributor

Hi @jsamantaucd We are preparing to restructure the examples and do not accept new framework-specific examples.

You can make it in a standalone repository and we can link it in our README, thanks.

@frostming frostming closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants