chore(kurtosis): Clean up Kurtosis and Support for Cloud Deployments #2401
+155
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezbera
force-pushed
the
kurtosis-party
branch
from
fa56f3c to
2e5c895
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2401 +/- ##
=======================================
Coverage 32.36% 32.36%
=======================================
Files 350 350
Lines 15592 15592
Branches 20 20
=======================================
Hits 5047 5047
Misses 10182 10182
Partials 363 363 |
rezbera
commented
Jan 23, 2025
kurtosis/beaconkit-local.yaml
Outdated
| @@ -71,9 +71,9 @@ network_configuration: | |||
| node_settings: | |||
| consensus_settings: | |||
| specs: | |||
| min_cpu: 0 | |||
| min_cpu: 1000 | |||
There was a problem hiding this comment.
If min is not set, then it defaults to max value on K8s
rezbera
commented
Jan 23, 2025
Comment on lines
-50
to
-56
| stop-gcp-devnet: | ||
| kurtosis enclave stop my-gcp-devnet2 | ||
|
|
||
| # Stops and removes the specified Kurtosis enclave | ||
| reset-gcp-devnet: | ||
| $(MAKE) stop-gcp-devnet | ||
| kurtosis enclave rm my-gcp-devnet2 |
There was a problem hiding this comment.
We can add more commands if they are useful but lets reduce bloat
rezbera
commented
Jan 23, 2025
| images: | ||
| beaconkit: northamerica-northeast1-docker.pkg.dev/prj-berachain-common-svc-01/berachain/beacon-kit:main |
There was a problem hiding this comment.
This is in a private image repo
calbera
reviewed
Jan 23, 2025
kurtosis/beaconkit-cloud.yaml
Outdated
Comment on lines
125
to
126
| - name: "otterscan" # otterscan supports only erigon nodes | ||
| client: "el-full-erigon-3" |
There was a problem hiding this comment.
how will this run if the erigon node isnt enabled?
There was a problem hiding this comment.
Removed otterscan as noone is using it afaik
rezbera
changed the title
rezbera
changed the title
calbera
reviewed
Jan 29, 2025
kurtosis/Makefile
Outdated
| # Starts a Kurtosis enclave in the cloud using the latest image tag | ||
| start-devnet-cloud: install-kurtosis | ||
| kurtosis run ./kurtosis --args-file ./kurtosis/beaconkit-cloud.yaml \ | ||
| --enclave my-cloud-devnet-$(shell whoami) --parallelism 200 --production |
There was a problem hiding this comment.
why remove the --image-download always tag?
nidhi-singh02
temporarily deployed
to
test-e2e
GitHub Actions
Inactive
shotes
pushed a commit
that referenced
this pull request
Feb 3, 2025
shotes
pushed a commit
that referenced
this pull request
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes to allow for easier run of Kurtosis on K8s based environments.
Main changes: