Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(E2E): Enable e2e tests to run in different networks based on chain spec #2403

Open
wants to merge 58 commits into
base: main
Choose a base branch
from

Conversation

nidhi-singh02
Copy link
Contributor

@nidhi-singh02 nidhi-singh02 commented Jan 23, 2025

As part of the change set, we will be able to spin up different networks on the basis of chain ID and the chain spec name combination each in its own kurtosis enclave and run the tests.

The instructions to add your tests is given in README.md.

This is the just the foundation of making the e2e tests customizable and being able to run different specs as part of our e2e suite.

Note : Currently only devnet is supported. I see hardcoding of chainspec in few tests, needs to be refactored.

nidhi-singh02 and others added 24 commits January 9, 2025 11:01
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Signed-off-by: nidhi-singh02 <[email protected]>
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 378 lines in your changes missing coverage. Please review.

Project coverage is 32.13%. Comparing base (1aff871) to head (aa5514f).

Files with missing lines Patch % Lines
testing/e2e/suite/setup.go 0.00% 302 Missing ⚠️
testing/e2e/suite/suite.go 0.00% 66 Missing ⚠️
testing/e2e/suite/options.go 0.00% 8 Missing ⚠️
testing/e2e/config/defaults.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2403      +/-   ##
==========================================
- Coverage   32.36%   32.13%   -0.24%     
==========================================
  Files         350      351       +1     
  Lines       15592    15708     +116     
  Branches       20       20              
==========================================
  Hits         5047     5047              
- Misses      10182    10298     +116     
  Partials      363      363              
Files with missing lines Coverage Δ
testing/e2e/config/config.go 0.00% <ø> (ø)
testing/e2e/config/defaults.go 0.00% <0.00%> (ø)
testing/e2e/suite/options.go 0.00% <0.00%> (ø)
testing/e2e/suite/suite.go 0.00% <0.00%> (ø)
testing/e2e/suite/setup.go 0.00% <0.00%> (ø)

@nidhi-singh02 nidhi-singh02 self-assigned this Jan 23, 2025
@nidhi-singh02
Copy link
Contributor Author

After merging changes from main, e2e tests started breaking. Debugging it.

@nidhi-singh02
Copy link
Contributor Author

Reasons for e2e failure :

  1. The chain ID for "testnet" spec has been changed from 80084 to 80069.
  2. Insufficient gas for sending the deposit transactions.

With above changes, getting new error only on testnet network. Shared it internally in our group.

In the current PR, e2e is passing as running everything on devnet.

@nidhi-singh02 nidhi-singh02 changed the title feat(E2E): Allow tests to run in different networks - WIP feat(E2E): Enable e2e tests to run in different networks based on chain spec Jan 29, 2025
@nidhi-singh02 nidhi-singh02 marked this pull request as ready for review January 29, 2025 09:47
@nidhi-singh02 nidhi-singh02 requested a review from a team as a code owner January 29, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants