chore(types): Cleanup unused types/funcs and expose Service Registry #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2440 +/- ##
==========================================
- Coverage 32.36% 32.36% -0.01%
==========================================
Files 350 350
Lines 15592 15594 +2
Branches 20 20
==========================================
Hits 5047 5047
- Misses 10182 10184 +2
Partials 363 363
|
rezbera
commented
Jan 30, 2025
|
|
||
| import "github.com/berachain/beacon-kit/errors" | ||
|
|
||
| var ( |
rezbera
commented
Jan 30, 2025
rezbera
commented
Jan 30, 2025
| @@ -97,46 +91,15 @@ type ( | |||
| /* -------------------------------------------------------------------------- */ | |||
|
|
|||
| type ( | |||
| // BeaconBlock type aliases. | |||
| ConsensusBlock = consruntimetypes.ConsensusBlock | |||
|
|
|||
rezbera
commented
Jan 30, 2025
| @@ -86,16 +86,6 @@ func (c Config) Template() string { | |||
| return template.TomlTemplate | |||
| } | |||
|
|
|||
| // MustReadConfigFromAppOpts reads the configuration options from the given | |||
| // application options. | |||
| func MustReadConfigFromAppOpts(opts AppOptions) *Config { | |||
calbera
reviewed
Jan 30, 2025
calbera
reviewed
Jan 30, 2025
abi87
reviewed
Jan 31, 2025
abi87
reviewed
Jan 31, 2025
rezbera
force-pushed
the
cleanup-unused-rez
branch
from
89dcc5f to
89b6ebd
Compare
rezbera
force-pushed
the
cleanup-unused-rez
branch
from
89b6ebd to
e2ceab3
Compare
rezbera
force-pushed
the
cleanup-unused-rez
branch
from
2f9f6cf to
7e03572
Compare
shotes
pushed a commit
that referenced
this pull request
Feb 3, 2025
shotes
pushed a commit
that referenced
this pull request
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up unused types and funcs, and exposes the Service Registry which allows us to fetch the various services such as Comet or Blockchain Service from the ABCI, which will support the future testing framework