chore(api): Dropped node api context generic #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abi87
commented
Feb 1, 2025
| @@ -46,8 +47,8 @@ func (h *Handler[ContextT]) GetState(c ContextT) (any, error) { | |||
| } | |||
| return beacontypes.StateResponse{ | |||
| // TODO: The version should be retrieved based on the slot | |||
| Version: "deneb", // stubbed | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
makes sense. latest version might not be necessary since we want to provide the version at which the incoming request is queried for. Would probably just require returning chainSpec.ActiveForkVersionForSlot(requestedSlot).String()
Signed-off-by: aBear <[email protected]>
abi87
force-pushed
the
drop-node-api-context-generic
branch
from
a957553 to
f91e75e
Compare
abi87
commented
Feb 1, 2025
| import "github.com/labstack/echo/v4" | ||
|
|
||
| type ( | ||
| Context = echo.Context |
There was a problem hiding this comment.
moved to handler package
abi87
commented
Feb 1, 2025
| ) | ||
|
|
||
| type Context = echo.Context |
There was a problem hiding this comment.
moved here from echo package to avoid import cycle
abi87
commented
Feb 1, 2025
| type VersionResponse struct { | ||
| Data struct { | ||
| Version string `json:"version"` | ||
| } `json:"data"` | ||
| } | ||
|
|
||
| response := VersionResponse{} | ||
| response.Data.Version = "1.0.0" | ||
| response.Data.Version = "1.1.0" |
There was a problem hiding this comment.
updated here just to signal that we should fix this
abi87
force-pushed
the
drop-node-api-context-generic
branch
from
228dd3d to
7bedccc
Compare
abi87
changed the title
shotes
pushed a commit
that referenced
this pull request
Feb 3, 2025
Signed-off-by: aBear <[email protected]>
shotes
pushed a commit
that referenced
this pull request
Feb 3, 2025
Signed-off-by: aBear <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the NodeAPIs context.
Apologies to @fridrik01 for stealing this