Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consensuswarn to CI pipeline #2462

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

crStiv
Copy link

@crStiv crStiv commented Feb 3, 2025

Closes #833

Changes:

  • Added consensuswarn to CI matrix
  • Created consensuswarn target in Makefile
  • Integrated consensuswarn into the linter suite

The tool will run as part of the standard CI checks to help maintain code quality and prevent consensus-related bugs early in development.

Signed-off-by: crStiv <[email protected]>
Signed-off-by: crStiv <[email protected]>
@crStiv crStiv requested a review from a team as a code owner February 3, 2025 00:18
@rezbera
Copy link
Contributor

rezbera commented Feb 3, 2025

https://github.com/orijtech/consensuswarn
Repo hasn't been updated in 6 months. Don't think we want to be adding unused and unmaintained tools. wdyt @abi87

@abi87
Copy link
Collaborator

abi87 commented Feb 3, 2025

https://github.com/orijtech/consensuswarn Repo hasn't been updated in 6 months. Don't think we want to be adding unused and unmaintained tools. wdyt @abi87

This is related to #833 which is marked goodFirstIssue so it's a fair attempt at contributing. I like the idea of the tool, but it's probably an overkill for us? We should discuss this.
Definitely this PR does not do all the job though: I believe we have to mark the proper functions to be warned about

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(ci): Investigating using https://github.com/orijtech/consensuswarn
3 participants