fix(x/evm): return error properly

berachain · Nov 2, 2023 · a097397 · a097397
1 parent 06b11bf
commit a097397
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/cosmos/x/evm/keeper/abci.go b/cosmos/x/evm/keeper/abci.go
@@ -34,16 +34,12 @@ func (k *Keeper) EndBlock(ctx context.Context) error {
 	blockNum := uint64(sdk.UnwrapSDKContext(ctx).BlockHeight())
 	block := k.chain.GetBlockByNumber(blockNum)
 	if block == nil {
-		panic(
-			fmt.Sprintf(
-				"EVM BLOCK %d FAILED TO PROCESS", blockNum,
-			),
+		return fmt.Errorf(
+			"evm block %d failed to process", blockNum,
 		)
 	} else if block.NumberU64() != blockNum {
-		panic(
-			fmt.Sprintf(
-				"EVM BLOCK [%d] DOES NOT MATCH COMET BLOCK [%d]", block.NumberU64(), blockNum,
-			),
+		return fmt.Errorf(
+			"evm block [%d] does not match comet block [%d]", block.NumberU64(), blockNum,
 		)
 	}
 	return nil