This repository has been archived by the owner on Jun 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsdevbear
force-pushed
the
calbera/plr-107-geth-txpool
branch
from
August 29, 2023 20:10
681a41e
to
2911a72
Compare
PLR-107 Geth TxPool
use wrapped geth txpool as app-side mempool, but not changing the block building yet. Refer to https://github.com/berachain/polaris/pull/810/files |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1041 +/- ##
==========================================
- Coverage 54.11% 51.92% -2.20%
==========================================
Files 101 100 -1
Lines 5353 5242 -111
==========================================
- Hits 2897 2722 -175
- Misses 2282 2345 +63
- Partials 174 175 +1
|
calbera
reviewed
Aug 29, 2023
Closed
itsdevbear
force-pushed
the
calbera/plr-107-geth-txpool
branch
from
August 30, 2023 04:27
50ec04f
to
4c2a7d4
Compare
Signed-off-by: Devon Bear <[email protected]>
calbera
reviewed
Aug 30, 2023
Signed-off-by: Devon Bear <[email protected]>
Signed-off-by: Devon Bear <[email protected]>
ocnc
previously approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it survived the load test
closing in favour of #1140 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.