Skip to content
This repository has been archived by the owner on Jun 9, 2024. It is now read-only.

refactor(pc): string -> [4]bytes #1059

Merged
merged 10 commits into from
Sep 6, 2023
Merged

refactor(pc): string -> [4]bytes #1059

merged 10 commits into from
Sep 6, 2023

Conversation

itsdevbear
Copy link
Member

@itsdevbear itsdevbear commented Sep 4, 2023

  • More performant
  • Remove unsafe and reflect usage

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #1059 (8ce4ce0) into main (a0dce68) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
- Coverage   54.09%   53.97%   -0.12%     
==========================================
  Files         102      101       -1     
  Lines        5341     5328      -13     
==========================================
- Hits         2889     2876      -13     
  Misses       2279     2279              
  Partials      173      173              
Files Changed Coverage Δ
eth/core/precompile/method.go 93.75% <ø> (ø)
eth/core/precompile/factories.go 86.04% <100.00%> (ø)
eth/core/precompile/method_validation.go 91.08% <100.00%> (-0.09%) ⬇️
eth/core/precompile/stateful_container.go 100.00% <100.00%> (ø)

@itsdevbear
Copy link
Member Author

todo: write a quick test to make sure it's not using the pointer memory address as the key by accident

@itsdevbear
Copy link
Member Author

good to merge

@itsdevbear itsdevbear added this pull request to the merge queue Sep 6, 2023
Merged via the queue into main with commit 599369c Sep 6, 2023
14 checks passed
@itsdevbear itsdevbear deleted the string- branch September 6, 2023 02:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants