chore(deps): geth v.1.13.4 and cosmos-sdk bump
#1288
Conversation
WalkthroughThe changes introduced in the codebase primarily focus on the configuration of the legacy transaction pool. The updates ensure that the Changes
Poem
TipsChat with CodeRabbit Bot (
|
itsdevbear
changed the title
geth v.1.13.4 and cosmos-sdk bumpgeth v.1.13.4 and cosmos-sdk bump
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- contracts/lib/forge-std (1 hunks)
- contracts/lib/solmate (1 hunks)
Files skipped from review due to trivial changes (2)
- contracts/lib/forge-std
- contracts/lib/solmate
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (17)
- build/tools/go.mod
- build/tools/go.sum
- contracts/go.mod
- contracts/go.sum
- cosmos/go.mod
- cosmos/go.sum
- e2e/localnet/go.mod
- e2e/localnet/go.sum
- e2e/precompile/go.mod
- e2e/precompile/go.sum
- e2e/testapp/go.mod
- e2e/testapp/go.sum
- eth/go.mod
- eth/go.sum
- go.work.sum
- lib/go.mod
- lib/go.sum
Files selected for processing (6)
- cosmos/runtime/txpool/handler.go (2 hunks)
- cosmos/runtime/txpool/handler_test.go (1 hunks)
- cosmos/runtime/txpool/mocks/geth_tx_pool.go (2 hunks)
- cosmos/runtime/txpool/mocks/tx_sub_provider.go (2 hunks)
- eth/eth.go (1 hunks)
- eth/polar/api_backend.go (1 hunks)
Additional comments: 9
cosmos/runtime/txpool/handler_test.go (1)
- 57-63: Ensure that all calls to
SubscribeTransactionsthroughout the codebase have been updated to match the new signature. Also, verify that theh.Start()function has been updated to handle the new arguments correctly.eth/polar/api_backend.go (1)
- 523-527: The function
SubscribeNewTxsEventhas been updated to callSubscribeTransactionsinstead ofSubscribeNewTxsEvent. Ensure that the new functionSubscribeTransactionsprovides the same functionality as the old one or that the changes are intended and correctly handled in the rest of the codebase.cosmos/runtime/txpool/mocks/tx_sub_provider.go (2)
22-34: The
SubscribeTransactionsmethod has been updated to include a new parameterreorgs. Ensure that all calls to this method throughout the codebase have been updated to match the new signature.38-68: The
TxSubProvider_SubscribeTransactions_Callstruct and its methods have been updated to reflect the changes in theSubscribeTransactionsmethod. This looks fine as long as the changes are consistent with the updated method.eth/eth.go (1)
- 50-56: The
SubscribeNewTxsEventfunction has been renamed toSubscribeTransactionsand now takes an additional boolean parameterreorgs. The return type of the functionSubscribeTransactionshas been changed toevent.Subscription. Ensure that all calls to this function throughout the codebase have been updated to match the new signature.- SubscribeNewTxsEvent(ch chan<- core.NewTxsEvent) event.Subscription + SubscribeTransactions(ch chan<- core.NewTxsEvent, reorgs bool) event.Subscriptioncosmos/runtime/txpool/handler.go (2)
51-55: The
SubscribeTransactionsmethod signature has been updated to include areorgsparameter. Ensure that all calls to this method throughout the codebase have been updated to match the new signature.136-142: The
SubscribeNewTxsEventmethod has been replaced withSubscribeTransactionsand thereorgsparameter is set totrue. This change should be verified to ensure it doesn't introduce any unexpected behavior.cosmos/runtime/txpool/mocks/geth_tx_pool.go (2)
209-221: The function
SubscribeTransactionshas been updated to take two arguments:chandreorgs. Ensure that all calls to this function throughout the codebase have been updated to match the new signature.228-254: The struct
GethTxPool_SubscribeTransactions_Calland its methods have been updated to reflect the changes in the function signatures. Ensure that all references to this struct and its methods throughout the codebase have been updated accordingly.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1288 +/- ##
=======================================
Coverage 48.54% 48.54%
=======================================
Files 84 84
Lines 4857 4857
=======================================
Hits 2358 2358
Misses 2325 2325
Partials 174 174
|
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- e2e/localnet/utils/utils.go (2 hunks)
Additional comments: 1
e2e/localnet/utils/utils.go (1)
- 22-28: The import of the
math/bigpackage seems to be unused in the provided code. Please ensure that it is used elsewhere in the code that is not shown here. If not, it should be removed to keep the code clean and avoid unnecessary imports.
itsdevbear
force-pushed
the
bump-geth-sdk
branch
from
bf4e2cc
to
34be780
Compare
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- e2e/localnet/utils/utils.go (2 hunks)
Additional comments: 1
e2e/localnet/utils/utils.go (1)
- 22-28: The import of the
math/bigpackage is new. Ensure that it is used correctly in the code.
Summary by CodeRabbit
New Features
Refactor