This repository has been archived by the owner on Jun 9, 2024. It is now read-only.
fix(mempool): allow sdk.Tx's to not fail checkTx
#1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe recent update in the codebase reflects a change in the transaction pool's behavior within a Cosmos-based blockchain system. The Changes
TipsChat with CodeRabbit Bot (
|
itsdevbear
added
merge me daddy
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- cosmos/runtime/txpool/mempool_test.go (1 hunks)
Additional comments: 1
cosmos/runtime/txpool/mempool_test.go (1)
- 83-87: The test case has been updated to reflect the new behavior of the
Insertfunction, which now allows non-Ethereum transactions to be inserted into the mempool without error. This change is consistent with the pull request's description and ensures that the test case will pass given the new logic. It's important to ensure that the rest of the system is compatible with this change and that it won't introduce any unexpected behavior elsewhere.
|
@BrickBera can u approve |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1318 +/- ##
==========================================
+ Coverage 48.45% 48.47% +0.01%
==========================================
Files 84 84
Lines 4870 4871 +1
==========================================
+ Hits 2360 2361 +1
Misses 2336 2336
Partials 174 174
|
BrickBera
approved these changes
Nov 20, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 20, 2023
this is bad but required <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved error handling for transaction processing, allowing for smoother handling of non-Ethereum transactions. - **Tests** - Updated test cases to reflect new behavior in transaction processing, ensuring non-Ethereum transactions are accepted without errors. <!-- end of auto-generated comment: release notes by coderabbit.ai --> (cherry picked from commit b12b9a5)
itsdevbear
added a commit
that referenced
this pull request
Nov 20, 2023
…1321) This is an automatic backport of pull request #1318 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> Co-authored-by: Devon Bear <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is bad but required
Summary by CodeRabbit
Bug Fixes
Tests