chore: cleanup around irrefutable let patterns #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this is broken on nightly and beta but passing on stable. I'll mark this as a draft until that gets sorted out. |
WillLillis
force-pushed
the
lints
branch
3 times, most recently
from
c23ce82 to
99cdf51
Compare
|
Looks like the issue is fixed now. If we run into any problems due to another regression, reverting/ adding a |
WillLillis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #160 and #156.
Now that we have the latest stable running in CI, we can clean up some of the noise around irrefutable let patterns, which we previously had to manually ignore with a clippy annotation.