-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove leading slash from paths on windows with colon drive separators #181
Conversation
I would be more than happy to, let me try and get back to you |
I've compiled from your fork with the branch, and replaced the original asm-lsp.exe in mason packages, and from there this is the log generated with the new asm-lsp Steps I took
Logs
One thing I noticed, is that when it doesn't find the project root which is supposed to be a But apart from that no luck, do let me know if I did any step wrong |
The server not detecting things properly when the It's unfortunate things still aren't working. I'll try to find some more time to spend on the issue this weekend. Thanks so much for taking a look! :) |
Explanation duplicated from #173: Ok so for some reason, when a path is canonicalized in Windows, it gets prefixed with "\?". That is, I may be completely missing something here, but I don't really understand why this convention is established if it isn't going to be followed consistently. The |
ef4fb19
to
47d3c3d
Compare
47d3c3d
to
95e9a57
Compare
…rators actually fix the problem
95e9a57
to
c1da7d6
Compare
After dealing with a number of issues surrounding how paths are communicated from various lsp clients on Windows, I believe this should fix #173. The basic idea is this:
Feels a little hacky, but in theory we should have a valid path after that.
@elli0t43 I don't currently have a full setup on Windows to test this with. I can get to that eventually, but if you have the time to test this fix that could really expedite things and would be greatly appreciated. :)