add avr opcodes #216
add avr opcodes #216
Conversation
Svarshick
commented
Jan 12, 2025
Svarshick
commented
- XML file has similar form to the x80 opcodes file with the following difference:
- Versions sections for different versions. If version has differences with other versions, it is named as . Other versions pointed as .
- Each InstructionForm section has "summary" instead of global summary for Instruction.
- SREG - status registers section.
- Encoding is split into nibbles due to the official doc format. There could be 32 and 16 bit commands.
- Clocks has problem with format because each section contains clocks of all versions. It should be discussed.
|
Thanks so much for taking the time to work on this! At a quick glance, everything in the xml file looks great! I should be able to work on the rust side this coming week to get these changes integrated soon. Could you also include the code you wrote to generate the xml file in this PR? It could live in |
|
P.S. Do you use telegram or any other platform when I can write to you? I
am not against email, but I would prefer other forms of communication if it
was convenient for you
…On Sun, 12 Jan 2025 at 22:50, Will Lillis ***@***.***> wrote:
Thanks so much for taking the time to work on this! At a quick glance,
everything in the xml file looks great! I should be able to work on the
rust side this coming week to get these changes integrated soon.
Could you also include the code you wrote to generate the xml file in this
PR? It could live in docs_store/opcodes/avr_xml_gen/.
—
Reply to this email directly, view it on GitHub
<#216 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCAMDXK6PFUQKFYXCYP2Y5D2KLBQ7AVCNFSM6AAAAABVBJFCUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBVHA4TIMZYGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
For some reason my messages were blocked...
I am glad to contribute. I feel like a part of something greater.
For better readability I will restructure the file organisation of the
project, add comments and split some logic into separate blocks. I have
pinned the current state of the code, so you can check it if you need.
However, would it be better to commit more readable code? I can work on it
this week, then commit it afterward
There are also AVR-Instructions pdf file
I saw that you have X. Would It be comfortable for you to communicate here?
…On Sun, 12 Jan 2025 at 22:50, Will Lillis ***@***.***> wrote:
Thanks so much for taking the time to work on this! At a quick glance,
everything in the xml file looks great! I should be able to work on the
rust side this coming week to get these changes integrated soon.
Could you also include the code you wrote to generate the xml file in this
PR? It could live in docs_store/opcodes/avr_xml_gen/.
—
Reply to this email directly, view it on GitHub
<#216 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCAMDXK6PFUQKFYXCYP2Y5D2KLBQ7AVCNFSM6AAAAABVBJFCUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBVHA4TIMZYGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
That sounds good to me. Where can I check out the project as it currently stands?
To an extent, but for something like this that's only going to run a few times, don't worry about it too much.
That works for me. And yeah, including the PDF file along with the code would be great!
Yeah X works for me. I'm also available on Discord (.lillis) and Matrix (@lillis:matrix.org). |
|
Everything looks good to me here, really looking forward to adding the generating code to the repo as well! :) |
