Do caldalv improvements #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor caldav readme * caldav: Add to docs + mind the +WAITING vtag, cancelled/completed difference * Fix back-updating from caldav -> tw ```bash t add kalimera # id: 1 tw_caldav_sync ... t mod 1 kalimera2 tw_caldav_sync # on subsequent syncs, the item 'kalimera2' would update caldav->tw because the description field was set in the former to "" and was unset in the latter. ``` We're also not accounting the `SYNCALL_TW_UUID` in the identical keys to compare since that exists in the caldav version but not in the TW one.
…ests to new test file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor caldav readme
caldav: Add to docs + mind the +WAITING vtag, cancelled/completed difference
Fix back-updating from caldav -> tw
We're also not accounting the
SYNCALL_TW_UUIDin the identical keys to compare since that exists in the caldav version but not in the TW one.Correct bug in TaskwarriorSide.items_are_identical
Move tw<>caldav tests to new test file and use proper parametrized pytest test cases