Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake/xplatform builds using github/tox/conda workflows #187

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

cmake/xplatform builds using github/tox/conda workflows #187

wants to merge 30 commits into from

Conversation

sarnold
Copy link
Contributor

@sarnold sarnold commented Oct 10, 2022 •
edited
Loading

  • add example workflows for CI and local development
  • enable cmake options for IPO, LLVM source coverage, really simple test
  • handles visibility a bit differently; see size of shared lib/executables with lto/ipo and namespace
  • builds on cmake PR Add 'pure' cmake build system #26 (includes commits and python update script)
  • demonstrates several toolchains/build methods across GH ci runners
  • includes some warning cleanup and edge-case build errors

Majority of changed files are new cmake files so it's fairly easy to see the actual source changes. I started this back when the cmake PR was fairly new, and then I got busy (so fresh rebase on current master).

From ubuntu-clang workflow:

-rwxr-xr-x 1 runner docker  16K Oct 10 19:23 ../staging/bin/abc
-rw-r--r-- 1 runner docker 5.0K Oct 10 19:15 ../staging/include/abc/abcapis.h
-rw-r--r-- 1 runner docker 3.4K Oct 10 19:15 ../staging/include/abc/abcapis_old.h
-rw-r--r-- 1 runner docker  826 Oct 10 19:16 ../staging/lib/cmake/abc/abcConfig-release.cmake
-rw-r--r-- 1 runner docker 4.8K Oct 10 19:16 ../staging/lib/cmake/abc/abcConfig.cmake
-rw-r--r-- 1 runner docker  13M Oct 10 19:23 ../staging/lib/libabc.so.1.1.0

sarnold
sarnold commented Oct 10, 2022
View reviewed changes
CMakeLists.txt
set(make_env ${CMAKE_COMMAND} -E env SDKROOT=${CMAKE_OSX_SYSROOT})
endif()

# run make to extract compiler options, linker options and list of source files
Copy link
Contributor Author

@sarnold sarnold Oct 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the requirement driving this; can you elaborate a little bit here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, that ^^ question was in regards to cmake docs, where it says:

"... It is intended to be set locally by the user creating a build tree. "

https://cmake.org/cmake/help/latest/variable/CMAKE_OSX_SYSROOT.html

@sarnold sarnold changed the title Github and tox workflows cmake/xplatform builds using github/tox/conda workflows Oct 19, 2022
@sarnold sarnold mentioned this pull request Nov 1, 2022
Open
@sarnold sarnold force-pushed the workflows branch 7 times, most recently from 91dae88 to 9a268ee Compare July 23, 2023 03:38
@sarnold
Copy link
Contributor Author

sarnold commented Jul 23, 2023 •
edited
Loading

Fresh rebase-on-the-rebase with some cleanup and timespec fix.

@sarnold sarnold force-pushed the workflows branch 4 times, most recently from ba547b1 to d63c541 Compare July 23, 2023 19:27
@sarnold sarnold force-pushed the workflows branch 14 times, most recently from a029c8b to 2d82a9d Compare December 2, 2023 04:08
@sarnold sarnold force-pushed the workflows branch 11 times, most recently from d0dfcbc to 65b372e Compare February 23, 2025 06:39
@sarnold
chg: dev: install or vendor googletest as needed, set gtest libs
ab1387e 
* apparently macos also needs gtest includes

Signed-off-by: Stephen L Arnold <[email protected]>
@sarnold
fix: dev: adjust for workflow environments, fix gia_test working dire…
ba03a93 
…ctory

* update gia_test source with language property
* update conda-dev env file and matrix xcode version
* update workflows with push branches and less generic job names

Signed-off-by: Stephen L Arnold <[email protected]>
@sarnold
chg: dev: cleanup readme and xcode setup, use internal gtest for xcode
9c460cd 
* fix adhoc test command arg file path, remove redundant test
* remove previous test path hacks, set xcode to Debug
* update conda build step and environment file, add core gtest deps

Signed-off-by: Stephen L Arnold <[email protected]>
@sarnold
fix: dev: cleanup googletest bits for consistent paths to gtest libs
d656cdd 
* use includes from source dir when using VENDOR_GTEST
* be sure and link against both gtest libs with either option

Signed-off-by: Stephen L Arnold <[email protected]>
@sarnold
fix: dev: try fetching googletest on windows instead of conda pkgs
74413d0 
Signed-off-by: Stephen L Arnold <[email protected]>
@sarnold sarnold force-pushed the workflows branch 7 times, most recently from 08ba36e to b35edf3 Compare February 24, 2025 05:27
@sarnold
fix: dev: refactor symbol visibility, use ABC_DLL to expose public API
9b57427 
* follow modern guidelines summarized in [1]
* set default visibility and visibility-inlines to hidden when
  using C++ namespace
* MSVC is hidden by default, so set GNU, LLVM, and AppleClang the same way
* use abc header defines to apply visibility rules on non-win32 platforms
* remove parallel args from tox Makefile commands in favor of posargs
  eg, ``tox -e abc -- -j4``

[1] https://gist.github.com/ax3l/ba17f4bb1edb5885a6bd01f58de4d542

Signed-off-by: Stephen L Arnold <[email protected]>
@sarnold sarnold force-pushed the workflows branch 2 times, most recently from 2cb0d1c to 4fc85fc Compare February 24, 2025 18:21
@sarnold
chg: dev: use static libs and local gtest in windows conda env
e3d76a1 
gia_test cmd fails with exit code and no useful traceback::

  FAILED: test/gia/gia_test.exe test/gia/gia_test[1]_tests.cmake D:/a/abc-fork/abc-fork/build/test/gia/gia_test[1]_tests.cmake
  C:\Windows\system32\cmd.exe /C "cd . && C:\mingw64\bin\c++.exe -g  test/gia/CMakeFiles/gia_test.dir/gia_test.cc.obj -o test\gia\gia_test.exe -Wl,--out-implib,test\gia\libgia_test.dll.a -Wl,--major-image-version,0,--minor-image-version,0  libabc.dll.a  lib/libgtest_main.dll.a  -lm  -lshlwapi  lib/libgtest.dll.a  -lkernel32 -luser32 -lgdi32 -lwinspool -lshell32 -lole32 -loleaut32 -luuid -lcomdlg32 -ladvapi32 && C:\Windows\system32\cmd.exe /C "cd /D D:\a\abc-fork\abc-fork\build\test\gia && C:\Miniconda\envs\abc-test\Library\bin\cmake.exe -D TEST_TARGET=gia_test -D TEST_EXECUTABLE=D:/a/abc-fork/abc-fork/build/test/gia/gia_test.exe -D TEST_EXECUTOR= -D TEST_WORKING_DIR=D:/a/abc-fork/abc-fork/build/test/gia -D TEST_EXTRA_ARGS= -D TEST_PROPERTIES= -D TEST_PREFIX= -D TEST_SUFFIX= -D TEST_FILTER= -D NO_PRETTY_TYPES=FALSE -D NO_PRETTY_VALUES=FALSE -D TEST_LIST=gia_test_TESTS -D CTEST_FILE=D:/a/abc-fork/abc-fork/build/test/gia/gia_test[1]_tests.cmake -D TEST_DISCOVERY_TIMEOUT=5 -D TEST_DISCOVERY_EXTRA_ARGS= -D TEST_XML_OUTPUT_DIR= -P C:/Miniconda/envs/abc-test/Library/share/cmake-3.31/Modules/GoogleTestAddTests.cmake""
  CMake Error at C:/Miniconda/envs/abc-test/Library/share/cmake-3.31/Modules/GoogleTestAddTests.cmake:132 (message):
    Error running test executable.

      Path: 'D:/a/abc-fork/abc-fork/build/test/gia/gia_test.exe'
      Working directory: 'D:/a/abc-fork/abc-fork/build/test/gia'
      Result: Exit code 0xc0000135

      Output:

  Call Stack (most recent call first):
    C:/Miniconda/envs/abc-test/Library/share/cmake-3.31/Modules/GoogleTestAddTests.cmake:275 (gtest_discover_tests_impl)

  ninja: build stopped: subcommand failed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarnold @madebr