Fix(write_hmetis): Remain the obj number when omitting POs explictly #373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue
The result of
write_hmetis
won't work on Mt-kahypar.Why this
This fix is actually from a test when partitioning on Mt-kahypar, I used to set a default$n$ shows up twice when collecting), but when iterating fanouts of AND object type, ID of POs still shows up in AND node's fanout data(on Hyperedges), so the nHyperNodesNum should still be
-s
to omit the POs explicitly (since the single connection between the PO and nodeAbc_NtkObjNum( pNtk )
.How to fix
Set
nHyperNodesNum
toAbc_NtkObjNum( pNtk )
even when omitting to a compact form.Verified result and detailed log
Running by
When skip by default
When no skip(redundant)
Full log of Skip and no Skip:
trace_no_skip.log
trace_skip_default.log
Notice
hmetis format does support comment at the end start with
%
, I find the result generated can't be parsed by Mt-kahypar unless you delete the comments:I added in the end, I also opened an issue here in Mt-kahypar, if any of you are interested.