Fix(Pointer): Fix the wrong value passed to size #374
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I used to change
nContent
to pointer in PR #362 , but missing this line when carelessly copy-paste the original implementation. The size of the malloced space is wrongly passed a pointer. When I read a librarysky130_fd_sc_hd__tt_025C_1v80.lib
, the crash shows, I believe this might also cause the issue #372 .Why didn't notice
I believe that the address of
nContent
is reinterpreted and casted to asize_t
inand sometimes this address is a large number and even memory check tool like leaks didn't notice.
How
nContents
to*nContents
Check
Before
After