Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid baseline #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Grid baseline #45

wants to merge 2 commits into from

Conversation

kjang96
Copy link
Collaborator

@kjang96 kjang96 commented Aug 16, 2018

View original conversation here:

https://github.com/berkeleyflow/flow-devel/pull/64

AboudyKreidieh
AboudyKreidieh approved these changes Aug 16, 2018
View reviewed changes
Copy link
Collaborator

@AboudyKreidieh AboudyKreidieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd feel more comfortable with this if it was tested, but otherwise LGTM.

kjang96 pushed a commit to kjang96/flow that referenced this pull request Aug 17, 2018
@nskh
Merge pull request berkeleyflow#45 from berkeleyflow/stress_test
46ad1f5 
adding stress tests used to diagnose race conditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AboudyKreidieh AboudyKreidieh AboudyKreidieh approved these changes

@cathywu cathywu Awaiting requested review from cathywu cathywu is a code owner

@eugenevinitsky eugenevinitsky Awaiting requested review from eugenevinitsky eugenevinitsky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjang96 @AboudyKreidieh