-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROR_INTR_001 #3
Open
lodyczekoladowe
wants to merge
23
commits into
beshu-tech:master
Choose a base branch
from
lodyczekoladowe:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ROR_INTR_001 #3
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
c908b9b
test
6833d96
Added Report-generation test
85faee9
Merge branch 'beshu-tech:master' into master
lodyczekoladowe 5af8958
Update e2e-tests/cypress/e2e/Report-generation.cy.ts
lodyczekoladowe bbe787a
Update elk-ror/conf/kbn/kibana.yml
lodyczekoladowe 5a1f6b2
Part of the requested changes
d595b45
Merge branch 'beshu-tech:master' into master
lodyczekoladowe e21ef59
All of requested changes. Waiting for pull request
4a01358
Self-generate invoices data, checking report generation process..
3622e05
Merge branch 'beshu-tech:master' into master
lodyczekoladowe b8ad596
Pipeline fix and logging improvement (#6)
coutoPL 0b75e9a
Sync 8.15.0 changes (#9)
coutoPL 879820b
Async rapport generating update
c2e51a0
Fork sync
7a24af6
Added Report-generation test
a031977
Update e2e-tests/cypress/e2e/Report-generation.cy.ts
lodyczekoladowe d693e38
Update elk-ror/conf/kbn/kibana.yml
lodyczekoladowe 0b1cb86
Part of the requested changes
d2aa9ba
All of requested changes. Waiting for pull request
0fe0e10
Self-generate invoices data, checking report generation process..
927f010
Async rapport generating update
86903a7
Merge remote-tracking branch 'origin/master'
49bfd44
Fixes for new version of es
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,26 +4,11 @@ on: | |
workflow_dispatch: | ||
schedule: | ||
- cron: '0 0 * * *' | ||
# pull_request: | ||
# types: [opened, synchronize, reopened] | ||
|
||
# jobs: | ||
# check-internal: | ||
# runs-on: ubuntu-latest | ||
# outputs: | ||
# is_member: ${{ steps.org_member_check.outputs.member }} | ||
# steps: | ||
# - name: Is PR creator an organization member? | ||
# id: org_member_check | ||
# uses: JamesSingleton/[email protected] | ||
# with: | ||
# organization: beshu-tech | ||
# username: ${{ github.actor }} | ||
# token: ${{ secrets.GITHUB_TOKEN }} | ||
pull_request: | ||
types: [opened, synchronize, reopened] | ||
|
||
jobs: | ||
e2e-tests: | ||
# needs: check-internal | ||
# if: needs.check-internal.outputs.is_member == 'true' || github.event.label.name == 'run-tests' | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
|
@@ -34,8 +19,9 @@ on: | |
- name: Run tests | ||
run: ./run-${{ matrix.version }}.sh | ||
env: | ||
ROR_ACTIVATION_KEY: ${{ secrets.ROR_KBN_LICENSE }} | ||
- name: S3 Upload Videos & logs | ||
ROR_ACTIVATION_KEY: ${{ secrets.ROR_KBN_LICENSE }} | ||
- name: S3 Upload Videos & show logs | ||
if: failure() | ||
env: | ||
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
import * as semver from 'semver'; | ||
import { Login } from '../support/page-objects/Login'; | ||
import { StackManagement } from '../support/page-objects/StackManagement'; | ||
import { KibanaNavigation } from '../support/page-objects/KibanaNavigation'; | ||
import { getKibanaVersion } from '../support/helpers'; | ||
|
||
describe('Kibana-content-overwrite', () => { | ||
beforeEach(() => { | ||
Login.initialization(); | ||
}); | ||
|
||
it('should overwrite Kibana alerting content', () => { | ||
const isAlertingOverwritePageVisible = () => { | ||
if (semver.gte(getKibanaVersion(), '8.6.0')) { | ||
cy.contains( | ||
'Kibana alerting does not work with ReadonlyREST, but we are working on an even better alerting and reporting solution.' | ||
).should('be.visible'); | ||
} else { | ||
cy.contains( | ||
'Kibana alerting does not work with ReadonlyREST, but we are working on an even better alerting and reporting solution.' | ||
).should('not.exist'); | ||
} | ||
}; | ||
|
||
if (semver.gte(getKibanaVersion(), '8.6.0')) { | ||
if (semver.gte(getKibanaVersion(), '8.14.0')) { | ||
StackManagement.openAlertsPage(); | ||
isAlertingOverwritePageVisible(); | ||
KibanaNavigation.openHomepage(); | ||
} | ||
StackManagement.openRulesPage(); | ||
isAlertingOverwritePageVisible(); | ||
|
||
KibanaNavigation.openHomepage(); | ||
|
||
StackManagement.openConnectorsPage(); | ||
isAlertingOverwritePageVisible(); | ||
} else { | ||
StackManagement.openRulesAndConnectorsPage(); | ||
isAlertingOverwritePageVisible(); | ||
} | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
import { Login } from "../support/page-objects/Login"; | ||
import { DataViews } from "../support/page-objects/management/DataViews"; | ||
import { Discover } from "../support/page-objects/Discover"; | ||
import { Reports } from "../support/page-objects/management/Reports"; | ||
import { dataPut } from "../support/page-objects/invoices"; | ||
|
||
describe('Report Generation', () => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I ran the test - it's way too SLOOOOW. |
||
const indexName: string = 'invoices'; | ||
const searchName: string = `${ indexName } search`; | ||
|
||
|
||
before(() => { | ||
dataPut(1000000, indexName, 600, 200); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "dataPut" doesn't tell much about what it does |
||
}); | ||
|
||
beforeEach(() => { | ||
Login.setLogin('user2:dev'); | ||
Login.initialization(); | ||
|
||
DataViews.deleteSavedObjectsIfExist([indexName, searchName]); | ||
Reports.deleteAllReports(searchName) | ||
|
||
Login.signOut(); | ||
}) | ||
|
||
it('should generate and verify reports for user2, and user3 should not see them', () => { | ||
Login.setLogin('user2:dev'); | ||
Login.initialization(); | ||
|
||
DataViews.createDataView(indexName); | ||
|
||
Discover.navigateTo(); | ||
|
||
Discover.selectDataView(indexName); | ||
Discover.saveSearch(searchName); | ||
|
||
for (let i = 0; i < 10; i++) { | ||
Discover.generateCsvReport(); | ||
} | ||
|
||
// Go to Reports and check if all reports are not empty | ||
Reports.navigateTo(); | ||
Reports.checkAllReports(searchName); | ||
|
||
Login.signOut(); | ||
|
||
Login.setLogin('user3:dev'); | ||
Login.initialization(); | ||
|
||
Reports.navigateTo(); | ||
Reports.verifyNoReports(); | ||
|
||
Login.signOut(); | ||
}); | ||
|
||
afterEach(() => { | ||
Login.setLogin('user2:dev'); | ||
Login.initialization(); | ||
|
||
DataViews.deleteSavedObjectsIfExist([indexName, searchName]); | ||
Reports.deleteAllReports(searchName) | ||
|
||
Login.signOut(); | ||
}) | ||
|
||
after(() => { | ||
cy.esDelete({ | ||
endpoint: indexName, | ||
credentials: 'kibana:kibana', | ||
}) | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see changes from my branch. For sure sth is wrong here.