Fixed camera failling to start and say text fixed #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TOTON95
commented
May 11, 2020
| @@ -8,7 +8,7 @@ | |||
| <rosparam param="source_list">["/vector/joint_states"]</rosparam> | |||
| </node> | |||
|
|
|||
| <node name="robot_state_publisher" pkg="robot_state_publisher" type="state_publisher"> | |||
| <node name="robot_state_publisher" pkg="robot_state_publisher" type="robot_state_publisher"> | |||
There was a problem hiding this comment.
ROS was complaining about a deprecation for this publisher
TOTON95
commented
May 11, 2020
|
|
||
| # connect to Vector | ||
| async_robot.connect() | ||
|
|
||
| # Camera feed? | ||
| async_robot.camera.init_camera_feed() |
There was a problem hiding this comment.
Here, the client was not able to connect with the robot, it said that the client was doing something else and blocks after this.
TOTON95
commented
May 11, 2020
| @@ -34,7 +34,7 @@ def battery_state_service_cb(self, request): | |||
| return response | |||
|
|
|||
| def say_text_cb(self, request): | |||
| self.robot.say_text(request.text) | |||
| self.robot.behavior.say_text(request.text) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @betab0t,
Would you consider some of the changes that I made to make work the driver on a physical device? I think that I overengineered my code in my camera script but it depends on how the tests work for you.
That aside, Digital Dreams Lab has shown its intentions to keep using this SDK, but is updating the functions every Friday. Would you like to keep updating these new functions?
Let me know what do you think of it.
Thanks in advance.