Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TUNE to OTHER category #413

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Conversation

antoni9
Copy link
Contributor

@antoni9 antoni9 commented Sep 9, 2023

Hi,

I created this tune as part of my frame bundle [100-euro-fpv.com] and now sharing it as a preset for BFC.

It contains multiple category changes - a full setup from a blank 4.4 flash, hence why it falls under the OTHER category.

Thanks for looking into this
Tony

limonspb
limonspb previously approved these changes Sep 11, 2023
@limonspb
Copy link
Member

limonspb commented Sep 11, 2023

Looking good. Surprizing to see that as a first PR to be clean.
minor question about this:

    set min_check = 1000
    set max_check = 2000

as far as i understand it only affects the stick commands.

haslinghuis
haslinghuis previously approved these changes Sep 11, 2023
@antoni9 antoni9 dismissed stale reviews from haslinghuis and limonspb via 3a0ef02 September 11, 2023 12:56
@antoni9
Copy link
Contributor Author

antoni9 commented Sep 11, 2023

@limonspb Thanks! The min/max checks increase perceived stick resolution, but you are right the min_ one should be >1000 otherwise BF will not ARM.

@limonspb
Copy link
Member

limonspb commented Sep 19, 2023

@limonspb Thanks! The min/max checks increase perceived stick resolution, but you are right the min_ one should be >1000 otherwise BF will not ARM.

i don't think it increases stick resolution. I was thinking the same before. But dug a little in the code and saw it's being used only for stick commands. Maybe @KarateBrot could double check to make sure? :)

@antoni9
Copy link
Contributor Author

antoni9 commented Sep 25, 2023

To expand on the "BF will not arm" statement - it will not arm because min_check is equal to the throttle min value of 1000 being received from a well calibrated radio, if the radio is calibrated to 998 there's no issue.

@limonspb
Copy link
Member

To expand on the "BF will not arm" statement - it will not arm because min_check is equal to the throttle min value of 1000 being received from a well calibrated radio, if the radio is calibrated to 998 there's no issue.

also for max check=2000, do the stick commands still work, if the radio is calibrated up to 1999?

@antoni9
Copy link
Contributor Author

antoni9 commented Sep 27, 2023

afaik, only min_check on throttle prevents arming, on other axes this only contributes to a tiny misalignment in the endpoint and presumably through the entire curve to compensate for the 1 - 2 ms difference. I have my radio outputting 998 - 2002 for symmetry.

@limonspb limonspb merged commit 68cc449 into betaflight:master Sep 27, 2023
1 check passed
@limonspb
Copy link
Member

afaik, only min_check on throttle prevents arming, on other axes this only contributes to a tiny misalignment in the endpoint and presumably through the entire curve to compensate for the 1 - 2 ms difference. I have my radio outputting 998 - 2002 for symmetry.

What i'm worried about, is that MAX_CHECK=2000 will block stick commands (like OSD menu, profile changes, etc) in case radio calibrated that way that it's not giving 2000, but lets say 1999

@antoni9 antoni9 deleted the Add-100-Euro-tune branch September 27, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants