Skip to content

Commit

Permalink
fix: validator
Browse files Browse the repository at this point in the history
  • Loading branch information
nicolasleger committed Nov 12, 2024
1 parent 06f788e commit 47f6953
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions lib/quote_validator/global.rb
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def validate_rge; end

# doit valider les mentions administratives associées à l'artisan
def validate_pro
@pro = @quote[:pro]
@pro = @quote[:pro] || {}
@errors << "pro_raison_sociale_manquant" if @pro[:raison_sociale].blank?
@errors << "pro_forme_juridique_manquant" if @pro[:forme_juridique].blank?
@errors << "tva_manquant" if @pro[:numero_tva].blank?
Expand All @@ -48,13 +48,13 @@ def validate_pro
@errors << "capital_manquant" if @pro[:capital].blank?
@errors << "siret_manquant" if @pro[:siret].blank?
# beaucoup de confusion entre SIRET (14 chiffres pour identifier un etablissement) et SIREN (9 chiffres pour identifier une entreprise)
@errors << "siret_format_erreur" if @pro[:siret].length != 14 && @pro[:siret].length.positive?
@errors << "siret_format_erreur" if @pro[:siret]&.length != 14 && @pro[:siret]&.length&.positive?
validate_pro_address
end

# doit valider les mentions administratives associées au client
def validate_client
@client = @quote[:client]
@client = @quote[:client] || {}
@errors << "client_prenom_manquant" if @client[:prenom].blank?
@errors << "client_nom_manquant" if @client[:nom].blank?
validate_client_address
Expand Down Expand Up @@ -83,7 +83,7 @@ def validate_address(address); end

# doit valider les critères techniques associés aux gestes présents dans le devis
def validate_works
works = @quote[:gestes]
works = @quote[:gestes] || []
works.each do |geste|
case geste[:type]

Expand Down
2 changes: 1 addition & 1 deletion lib/quote_validator/isolation.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module QuoteValidator
class Isolation < Base
# doit valider les critères techniques associés aux gestes présents dans le devis
def validate
works = @quote[:gestes]
works = @quote[:gestes] || []
works.each do |geste|
case geste[:type]

Expand Down

0 comments on commit 47f6953

Please sign in to comment.