[TRELLO-2781] Improve errors

betagouv · Mar 4, 2025 · 4531102 · 4531102
1 parent 16f0a62
commit 4531102
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/app/controllers/error/AppError.scala b/app/controllers/error/AppError.scala
@@ -664,4 +664,12 @@ object AppError {
       s"Le signalement $id n'est pas réattribuable"
     override val titleForLogs: String = "report_not_reattributable"
   }
+
+  final case object CantReattributeToTheSameCompany extends BadRequestError {
+    override val scErrorCode: String = "SC-0073"
+    override val title: String       = s"Report is not reattributable"
+    override val details: String =
+      "Vous ne pouvez pas réattribuer ce signalement à la même entreprise"
+    override val titleForLogs: String = "report_not_reattributable"
+  }
 }
diff --git a/app/orchestrators/ReportOrchestrator.scala b/app/orchestrators/ReportOrchestrator.scala
@@ -1184,7 +1184,7 @@ class ReportOrchestrator(
     _ <- if (maybeProResponseDate.nonEmpty) Future.unit else Future.failed(ReportNotReattributable(reportId))
     _ <- validateCompany(companyCreation.activityCode, Some(companyCreation.siret))
     _ <-
-      if (report.companySiret.contains(companyCreation.siret)) Future.failed(ReportNotReattributable(reportId))
+      if (report.companySiret.contains(companyCreation.siret)) Future.failed(CantReattributeToTheSameCompany)
       else Future.unit
     company        <- companyRepository.getOrCreate(companyCreation.siret, toCompany(companyCreation))
     reportFilesMap <- reportFileOrchestrator.prefetchReportsFiles(List(reportId))