Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEP TRELLO-2934 redirect old attachment endpoint to new one #1907

Merged
merged 1 commit into from
Mar 4, 2025
+14 −9
Merged

MEP TRELLO-2934 redirect old attachment endpoint to new one #1907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions app/controllers/ReportFileController.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,20 +43,21 @@ class ReportFileController(

val logger: Logger = Logger(this.getClass)

val reportFileMaxSizeInBytes = signalConsoConfiguration.reportFileMaxSize * 1024 * 1024
private val reportFileMaxSizeInBytes = signalConsoConfiguration.reportFileMaxSize * 1024 * 1024

def legacyDownloadReportFile(uuid: ReportFileId, filename: String): Action[AnyContent] =
Act.public.generousLimit.async { req =>
// Temporary to understand where the remaining calls are coming from : api calls by ReponseConso ? some frontend that was not updated?
logger.warnWithTitle(
logger.infoWithTitle(
"legacyDownloadReportFile",
s"call of legacyDownloadReportFile by user agent ${req.headers
.get(USER_AGENT)} and api key ${req.headers.get("X-Api-Key").map(_.slice(0, 4))}"
.get(USER_AGENT)}}"
)
Future.successful(
// This legacy endpoint was not secured and could serve any attachments.
// We think it's still used by some agents, so this new endpoint
// should do the trick (requires login and only works on attachments linked to a report)
Redirect(routes.ReportFileController.downloadFileUsedInReport(fileId = uuid, filename = filename))
)

reportFileOrchestrator
.legacyDownloadReportAttachment(uuid, filename)
.map(signedUrl => Redirect(signedUrl))
}

def downloadFileNotYetUsedInReport(uuid: ReportFileId, filename: String): Action[AnyContent] =
Expand Down
6 changes: 5 additions & 1 deletion conf/routes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ GET /api/reports/files/temporary/:fileId/:filename controller
# for deleting an attachment that was uploaded but the report isn't submitted yet
# also used in the dashboard for the pro when his response isn't submitted yet
DELETE /api/reports/files/temporary/:fileId/:filename controllers.ReportFileController.deleteFileNotYetUsedInReport(fileId: ReportFileId, filename)
# this next one is LEGACY, to be removed very soon, once the frontend is updated (was used both in website and dashboard)

# Legacy endpoint. Redirects to another endpoint, that is more secure
# It is not used in the frontends anymore, but we still see some calls in New Relic
# We think it's DGCCRF agents who still have the URL from an Excel export
# Could probably be removed in a few weeks/months
GET /api/reports/files/:uuid/:filename controllers.ReportFileController.legacyDownloadReportFile(uuid: ReportFileId, filename)

# For the conso, to reattribute a report if the pro said he was not concerned
Expand Down