Rebase

.github/workflows/python-integration.yml

@@ -33,7 +33,7 @@ jobs:
         pip install -r requirements/test.txt
     - name: Start the Postgres service
       run: |
-        docker-compose -f postgres/docker-compose.yml up --build -d
+        docker compose -f postgres/docker-compose.yml up --build -d
     - name: Wait for Postgres to become available
       run: |
         until docker run --network container:postgres_postgres_1 postgres_postgres pg_isready -h postgres -p 5432 -U shillelagh --timeout=90; do sleep 10; done
@@ -46,4 +46,4 @@ jobs:
       if: always()
       run: |
         docker logs postgres_postgres_1
-        docker-compose -f postgres/docker-compose.yml down
+        docker compose -f postgres/docker-compose.yml down

.github/workflows/python-package-daily.yml

@@ -30,12 +30,6 @@ jobs:
       run: |
         python -m pip install --upgrade pip setuptools
         python -m pip install -e '.[testing]'
-    - name: Install multicorn2
-      run: |
-        git clone https://github.com/pgsql-io/multicorn2.git
-        cd multicorn2
-        git checkout v2.5
-        pip install -e '.[testing]'
     - name: Test with pytest
       run: |
         pytest --cov-fail-under=100 --cov=src/shillelagh -vv tests/ --doctest-modules src/shillelagh --without-integration --without-slow-integration

.github/workflows/python-package.yml

@@ -31,12 +31,6 @@ jobs:
       run: |
         python -m pip install --upgrade pip setuptools
         python -m pip install -r requirements/test.txt
-    - name: Install multicorn2
-      run: |
-        git clone https://github.com/pgsql-io/multicorn2.git
-        cd multicorn2
-        git checkout v2.5
-        pip install -r requirements/test.txt
     - name: Test with pytest
       run: |
         pre-commit run --all-files

docs/postgres.rst

@@ -18,6 +18,6 @@ The ``postgres/`` directory has a Docker configuration that can be used to test
 
 .. code-block:: bash
 
-   docker-compose up --build -d
+   docker compose up --build -d
 
 You should then be able to run the example script in `examples/postgres.py`_ to test that everything works.

examples/postgres.py

@@ -9,7 +9,7 @@
 Postgres with the extension and the Python packages. Just run:
 
     $ cd postgres/
-    $ docker-compose up --build -d
+    $ docker compose up --build -d
 
 Then you can run this script.
 """

src/shillelagh/backends/multicorn/db.py

@@ -2,13 +2,13 @@
 """
 A DB API 2.0 wrapper.
 """
+
 import logging
 import re
 from typing import Any, Dict, List, Optional, Tuple, Type, Union, cast
 from uuid import uuid4
 
 import psycopg2
-from multicorn import ForeignDataWrapper, Qual, SortKey
 from psycopg2 import extensions
 
 from shillelagh.adapters.base import Adapter
@@ -20,14 +20,12 @@
     IntegrityError,
     InterfaceError,
     InternalError,
-    NotSupportedError,
     OperationalError,
     ProgrammingError,
     Warning,
 )
 from shillelagh.lib import (
     combine_args_kwargs,
-    deserialize,
     escape_identifier,
     find_adapter,
     serialize,
@@ -46,7 +44,29 @@
     Timestamp,
     TimestampFromTicks,
 )
-from shillelagh.typing import Row
+
+__all__ = [
+    "DatabaseError",
+    "DataError",
+    "Error",
+    "IntegrityError",
+    "InterfaceError",
+    "InternalError",
+    "OperationalError",
+    "BINARY",
+    "DATETIME",
+    "NUMBER",
+    "ROWID",
+    "STRING",
+    "Binary",
+    "Date",
+    "DateFromTicks",
+    "Time",
+    "TimeFromTicks",
+    "Timestamp",
+    "TimestampFromTicks",
+    "Warning",
+]
 
 apilevel = "2.0"
 threadsafety = 2

src/shillelagh/backends/multicorn/dialects/base.py

@@ -18,7 +18,6 @@
 
 
 class Multicorn2Dialect(PGDialect_psycopg2):
-
     """
     A SQLAlchemy dialect for Shillelagh based on psycopg2 and multicorn2.
     """