feat(genericjsonapi): add url_configs keyword arg #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vergenzt
commented
Sep 25, 2024
vergenzt
force-pushed
the
vergenzt/add-request-headers-by-origin
branch
3 times, most recently
from
1a76df9
to
99bf011
Compare
vergenzt
changed the title
vergenzt
force-pushed
the
vergenzt/add-request-headers-by-origin
branch
from
99bf011
to
5852e6f
Compare
vergenzt
changed the title
vergenzt
force-pushed
the
vergenzt/add-request-headers-by-origin
branch
3 times, most recently
from
dac1662
to
ffce495
Compare
vergenzt
force-pushed
the
vergenzt/add-request-headers-by-origin
branch
from
ffce495
to
bd51bb3
Compare
vergenzt
force-pushed
the
vergenzt/add-request-headers-by-origin
branch
from
bd51bb3
to
c42165c
Compare
|
Hey @betodealmeida! I made a couple changes in approach to this PR. Would you mind re-reviewing and letting me know if you have any feedback or concerns? 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows headers & other adapter kwargs to be restricted to specific URL patterns!
Also included two other minor fixes.
I believe added unit tests for all new behavior.
Let me know what you think!