Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Merge from dotnet/runtime #72

Merged
merged 228 commits into from
Feb 25, 2024
Merged

Conversation

MichalStrehovsky
Copy link
Member

No description provided.

akoeplinger and others added 30 commits October 25, 2023 16:44
* Pin the SdkVersionForWorkloadTesting to 1.xx for now

* Work around illink 8.0.0 not being locally built for now

* Disable downlevel tests targetting unreleased versions
* [release/8.0] Stable branding for .NET 8 GA

* Handle an empty bandPreleaseVersion

* [release/8.0] Update dependencies from dotnet/emsdk (#93801)

* Update dependencies from https://github.com/dotnet/emsdk build 20231020.2

Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport
 From Version 8.0.0-rtm.23511.3 -> To Version 8.0.0-rtm.23520.2

* switch to the stable version now

* Update dependencies

* Also fix the trigger

* pin the wbt sdk to avoid the latest analizer nonsense

* Use source generation for the serializer

* Try to make sourcebuild happy

* Try again to make sourcebuild happy

* Use reflection and suppress trim analysis instead

This reverts commit 768b65bab585f303bca6e0e9a36cf06d59e90387.

* Fix reverting too much

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Larry Ewing <[email protected]>

* [release/8.0] Update APICompat settings under source build (#93865)

* Update APICompat settings under source build

* Update resolveContract.targets

---------

Co-authored-by: Viktor Hofer <[email protected]>

* Override InformationalVersion for NativeAOT corelib too

* [release/8.0] Improve performance of UnmanagedMemoryStream (#93812)

* Improve performance of UnmanagedMemoryStream

UnmanagedMemoryStream used Interlocked operations to update its state to prevent tearing of 64-bit values on 32-bit platforms. This pattern is expensive in general and it was found to be prohibitively expensive on recent hardware..

This change removes the expensive Interlocked operations and addresses
the tearing issues in alternative way:
- The _length field is converted to nuint that is guaranteed to be
  updated atomically.
- Writes to _length field are volatile to guaranteed the
  unininitialized memory cannot be read.
- The _position field remains long and it has a risk of tearing. It is
  not a problem since tearing of this field cannot lead to buffer
  overruns.

Fixes #93624

* Add comment

---------

Co-authored-by: Jan Kotas <[email protected]>

* Update dependencies from https://github.com/dotnet/emsdk build 20231023.2 (#93881)

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.0-rtm.23520.2 -> To Version 8.0.0-rtm.23523.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* [release/8.0] Update dependencies from dnceng/internal/dotnet-optimization (#93827)

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20231021.3

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23519.5 -> To Version 1.0.0-prerelease.23521.3

* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20231021.3

optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime , optimization.PGO.CoreCLR
 From Version 1.0.0-prerelease.23519.5 -> To Version 1.0.0-prerelease.23521.3

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* [release/8.0][wasm] Fix perf pipeline runs (#93888)

* Remove --experimental-wasm-eh argument from the wasm_args used for wasm performance runs. (#93357)

(cherry picked from commit a770017)

* performance-setup.sh: Use `release/8.0` as the default channel

* performance-setup.ps1: use release/8.0 as the default channel

* Fix passing wasmArgs for bdn

---------

Co-authored-by: Parker Bibus <[email protected]>

* [release/8.0] Honor JsonSerializerOptions.PropertyNameCaseInsensitive in property name conflict resolution. (#93935)

* Honor JsonSerializerOptions.PropertyNameCaseInsensitive in property name conflict resolution.

* Update src/libraries/System.Text.Json/tests/Common/PropertyNameTests.cs

Co-authored-by: Jeff Handley <[email protected]>

* Address feedback

---------

Co-authored-by: Eirik Tsarpalis <[email protected]>
Co-authored-by: Jeff Handley <[email protected]>

* [8.0] Update MsQuic (#93979)

* Try pinning the installer version to a 8.01xx sdk

* Target net8.0 in SatelliteAssemblyFromProjectRef

---------

Co-authored-by: Carlos Sánchez López <[email protected]>
Co-authored-by: Larry Ewing <[email protected]>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Viktor Hofer <[email protected]>
Co-authored-by: Alexander Köplinger <[email protected]>
Co-authored-by: Jan Kotas <[email protected]>
Co-authored-by: Ankit Jain <[email protected]>
Co-authored-by: Parker Bibus <[email protected]>
Co-authored-by: Eirik Tsarpalis <[email protected]>
Co-authored-by: Jeff Handley <[email protected]>
…0-staging

[manual] Merge branch 'release/8.0' => 'release/8.0-staging'
…es in options source gen (#94062)

Co-authored-by: Tarek Mahmoud Sayed <[email protected]>
…ild 20231023.2 (#93872)

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.23518.2 -> To Version 8.0.0-alpha.0.23523.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
….2 (#93873)

Microsoft.NETCore.Runtime.ICU.Transport
 From Version 8.0.0-rtm.23511.1 -> To Version 8.0.0-rtm.23523.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…s (#94037)

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20231025.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23516.2 -> To Version 3.11.0-beta1.23525.2

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20231025.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23516.2 -> To Version 3.11.0-beta1.23525.2

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20231025.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23516.2 -> To Version 3.11.0-beta1.23525.2

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20231025.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23516.2 -> To Version 3.11.0-beta1.23525.2

* Update dependencies from https://github.com/dotnet/roslyn-analyzers build 20231025.2

Microsoft.CodeAnalysis.Analyzers , Microsoft.CodeAnalysis.NetAnalyzers
 From Version 3.11.0-beta1.23516.2 -> To Version 3.11.0-beta1.23525.2

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
… types. (#94267) (#94307)

* Use fully qualified names when referencing user types. (#94267)

* Use fully qualified names when referencing user types.

* Use ToUpperInvariant

* Address feedback

* Update Servicing version.
…rtual generic methods (#94469)

* [mono] [imt] Don't increment vt_slot for non-virtual generic methods

Interfaces can have static generic methods, for example.  They don't
have a vt_slot.

When building an IMT slot, we need to collect all the interface
methods that map to a particular IMT slot along with their
implementing vtable entries.  To do that, vt_slot starts at the
interface offset of a particular interface and keeps incrementing as
we iterate over the methods of the interface.  It is crtitical that
vt_slot is accurate - otherwise we may dispatch the interface call to
the wrong virtual method.

Fixes dotnet/runtime#93770

* [mono][imt] remove dead appdomain code

the extra_interfaces argument was used to implement additional
interfaces on cross-domain transparent proxy objects.

* [mono][imt] fixup ifdefed debug code

* Add test case

---------

Co-authored-by: Aleksey Kliger <[email protected]>
… (#94309)

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20231102.2

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.23523.2 -> To Version 8.0.0-alpha.0.23552.2

* Update dependencies from https://github.com/dotnet/hotreload-utils build 20231106.2

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 8.0.0-alpha.0.23523.2 -> To Version 8.0.0-alpha.0.23556.2

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…4070)

* Fix Decimal literal formatting in source generators

Both ConfigurationBinder and Json were not handling decimal values
correctly.  This shares and updates our workaround method for formatting
these.

* Address feedback

* Fix binding types with optional string parameters (#93563)

* Add a baseline test for constructor parameters

* Fix binding types with optional string parameters

Ensure the source generator emits the declaration with default value for
all cases when we emit the bind logic.

* Add a test case that uses a Primary Constructor with default values

* Split baseline data for added test.

* Fix .NETFramework test baseline

* Update baselines after global namespace change
# Conflicts:

* Update added baseline after global:: change

---------

Co-authored-by: Eric StJohn <[email protected]>
* Linux Kernel Regression Socket Test Failures Disable

* Fix formatting

* Delete spaces

* Format Connect.cs

* Revert "Format Connect.cs"

This reverts commit 6ee1383a1d300668654d26cdb085b21f8f70f722.

* Add spaces again
* Update dependencies from https://github.com/dotnet/emsdk build 20231030.2

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.0-rtm.23523.2 -> To Version 8.0.0-rtm.23530.2

* Update dependencies from https://github.com/dotnet/emsdk build 20231108.2

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.0-rtm.23523.2 -> To Version 8.0.0-rtm.23558.2

* Update dependencies from https://github.com/dotnet/emsdk build 20231108.4

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.0-rtm.23523.2 -> To Version 8.0.1-rtm.23558.4

* Update dependencies from https://github.com/dotnet/emsdk build 20231109.1

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.0-rtm.23523.2 -> To Version 8.0.1-servicing.23559.1

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Carlos Sánchez López <[email protected]>
…ld 20231108.5 (#94568)

Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Data.Common.TestData , System.Drawing.Common.TestData , System.Formats.Tar.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Text.RegularExpressions.TestData , System.Windows.Extensions.TestData
 From Version 8.0.0-beta.23421.1 -> To Version 8.0.0-beta.23558.5

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…ay], add XML docs (#94343)

* Remove [EditorBrowsable] from [InlineArray]

* Add XML comments

* Tweak XML docs following review comments

Co-authored-by: Stephen Toub <[email protected]>

---------

Co-authored-by: Sergio Pedri <[email protected]>
Co-authored-by: Stephen Toub <[email protected]>
* Update Alpine Arm32 image

* TO REVERT: test specifically linux_musl_arm platform

* Pin the image to previous tag

* Revert "TO REVERT: test specifically linux_musl_arm platform"

This reverts commit 63b83026f62259dcc8cde810d94f041a5ab5c918.
…o_debug_lookup_source_location (#94612)

Backport of #94540 to release/8.0-staging

If a newly added method is in a stack trace, look it up in the EnC debug information, if available.

Related to #93860

* Add new crashing test

* [mono] catch the case of updated methods in mono_debug_lookup_source_location

Co-authored-by: Aleksey Kliger <[email protected]>
Co-authored-by: Thays Grazia <[email protected]>
github-actions bot and others added 28 commits February 9, 2024 12:01
When inlining a method, all arguments are first copied to new vars. Ldarga is going to be applied on these copies. We were loading the address of the wrong var due to typo.
…ono_gsharedvt_constrained_call (). (#97721) (#97850)

Fixes dotnet/runtime#97625.

Co-authored-by: Larry Ewing <[email protected]>
… release/8.0-staging (#98182)

- Reflection IsAssignableFrom api
- As well as constraint checking
…97352)

* Move a lock to protect m_pDynamicStaticsInfo

* apply feedback

* cast to LONG

* Fix access to m_pDynamicStaticsInfo (#97353)

- Remove race condition where it is possible that an updated dynamic statics info pointer is published without ensuring that the data is also considered written.
- Use VolatileLoadWithoutBarrier at the read site (where locks are not taken) to ensure that there are no difficult to examine reads of this pointer.

---------

Co-authored-by: Hyungju Lee <[email protected]>
Co-authored-by: David Wrighton <[email protected]>
…ect behavior on overshift (#98001) (#98066)

* Ensure that constant folding for SIMD shifts on xarch follow the correct behavior on overshift

* Ensure we test Sse2.IsSupported
…umber` APIs optimize correctly (#98159)

* Ensure that the various `Max*Number` and `Min*Number` APIs optimize correctly

* Don't mark the test methods as AO

* Add a missing using statement to the test

---------

Co-authored-by: Tanner Gooding <[email protected]>
… operations involving Vector2.One (#98150)

MultiplyByScalar on ARM64 should not be handled by the same path
as other multiplications since it has different behavior.
… (#97856)

* use ld_classic in ILC build and in build integration

* PR feedback

* Maybe fix the build for non-apple

* Update src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets

PR feedback

Co-authored-by: Jan Kotas <[email protected]>

---------

Co-authored-by: Jan Kotas <[email protected]>
… (#98249)

We were propagating state from each type in the method signature to the
comparisons for the next type. This resulted in type equivalence checks
being disabled for any parameters that came after a generic parameter.
* Update dependencies from https://github.com/dotnet/emsdk build 20240123.1

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.2-servicing.24062.1 -> To Version 8.0.2-servicing.24073.1

* Update dependencies from https://github.com/dotnet/emsdk build 20240208.3

Microsoft.SourceBuild.Intermediate.emsdk , Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100
 From Version 8.0.2-servicing.24062.1 -> To Version 8.0.3-servicing.24108.3

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Carlos Sánchez López <[email protected]>
…ate at max iteration limit (#97927)

* Fix regex lazy loop handling of backtracking state at max iteration limit

Upon entering a lazy loop, state is pushed onto the backtracking stack if the lazy loop might be backtracked into.  That state is then dutifully popped off when unwinding the loop due to failure to match. However, if the loop successfully matches its maximum number of times but still fails because of a failure after the lazy loop, the state still needs to be popped off the stack, but isn't. This fixes that.

* Add a few more test variations

---------

Co-authored-by: Stephen Toub <[email protected]>
… Vector64/128/256 (#98115)

* Ensure that Vector512 uses the same patterns as Vector64/128/256

* Update src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Vector512.cs

Co-authored-by: Jeff Handley <[email protected]>

---------

Co-authored-by: Tanner Gooding <[email protected]>
Co-authored-by: Jeff Handley <[email protected]>
…(#96847)

* RemoveAllKeyed use Equals for matching

This brings RemoveAllKeyed in line with service resolution (ServiceProvider.GetRequiredKeyedService)

* Use equals for TryAdd and Replace

* Add packaging info to csproj

---------

Co-authored-by: Tommy Sørbråten <[email protected]>
Co-authored-by: Steve Harter <[email protected]>
[manual] Merge release/8.0-staging into release/8.0
…4-02-13-1022

Merging internal commits for release/8.0
…213.2 (#98443)

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.24059.4 -> To Version 8.0.0-beta.24113.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@MichalStrehovsky MichalStrehovsky merged commit d289362 into bflat-release/8.0 Feb 25, 2024
7 checks passed
@MichalStrehovsky MichalStrehovsky deleted the rel branch February 25, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.