Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a special case for square input images where we need to resize to the target as intermediary, which can be considered a safe operation #1281

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

bghira
Copy link
Owner

@bghira bghira commented Jan 18, 2025

this impacts square image inputs, which slipped by initial tests since the debug image creation misses the very last step of creating a final output.

if you were using crop=false and had square images which differ from the resolution, this would cause problems like zoomed and cropped elements.

… the target as intermediary, which can be considered a safe operation
@bghira bghira merged commit bfff2ed into main Jan 18, 2025
1 check failed
@bghira bghira deleted the bugfix/square-image-no-crop branch January 18, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant