Add "ParameterURL" metadata field #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
arokem
approved these changes
May 15, 2024
| @@ -393,7 +394,8 @@ Dictionary `"ResponseFunction"` has the following reserved keywords: | |||
| "FitMethod": "ols", | |||
| "OutlierRejectionmethod": "None" | |||
| } | |||
| } | |||
| }, | |||
| "ParameterURL": "https://doi.org/10.1002/nbm.1940080707" | |||
There was a problem hiding this comment.
Small quibble, but maybe this one is a better reference?
Suggested change
| "ParameterURL": "https://doi.org/10.1002/nbm.1940080707" | |
| "ParameterURL": "https://doi.org/10.1016/j.jmr.2011.09.022" |
I believe it's the first reference to the 0-1 normalized FA
There was a problem hiding this comment.
I'd always had it in my mind that the right citation for FA was the 1996 one. I was just looking through my Zotero and saw the 1995 one, questioned it, found this, and thought maybe all my citations of the 1996 one were erroneous:
I had not realised that it's different to the 1996 one:
Is the first one then a mathematical error?
|
Oh - interesting! Yes, I think that the 1995 is the correct reference here, and also yes: I think that paper has a math error in it (I see no other explanation). Funny. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One aspect of the "model fit parameters" vs. "model-derived parameters" distinction is that sometimes an individual can propose taking the outcomes of some model fitting process and compute some novel derivative measure from those data, and the relevant reference for that derived parameter may be different to that of the model itself. Eg. The original 1994 DTI paper doesn't present FA.
With #92, metadata relating to "the model" is encapsulated within its own metadata dictionary, and there a URL can be provided for the model. With this PR I propose that in some instances it may be desired to provide a URL that describes just the specific parameter that is encoded in the corresponding data file.