-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BEP: DICOM "file-format" support #1551
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1551 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 16 16
Lines 1356 1356
=======================================
Hits 1191 1191
Misses 165 165 ☔ View full report in Codecov by Sentry. |
- Duplication of metadata between `.dcm` and BIDS-sidecar `.json`. | ||
- This issue is not new or specific to DICOM: it needs to be addressed conceptually in BIDS (https://github.com/bids-standard/bids-specification/pull/761). | ||
- In fact, it offers a **benefit** of metadata harmonization, particularly when DICOM or manufacturers do not yet provide information in non-manufacturer-specific sections of DICOM. | ||
- Libraries needed to support DICOM I/O to support BIDS: experiences with `dcm2niix` suggest that it remains a challenge to consistently access imaging data from DICOMs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neurolabusc please have a look at this BEP idea and please express yourself -- your experience and knowledge would be of the most value here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am agnostic about this. The issue with DICOM is that it is like the English language, which is used differently by different individuals (e.g. pants
means something different in the USA than the UK). Each manufacturer has its own definitions, can use terms like RepetitionTime
differently, and uses private tags for a lot of details. This seems like an aspirational goal, but it seems like the initial work must come from harmonization efforts by the DICOM work groups.
Assuming a user wants to make a DICOM-based BIDS dataset, how does the BIDS validator work? Consider a Philips fMRI time series, where that manufacturer has no method for defining slice timing. What tool will be used to inject required details not in the raw DICOM? Do we need to define a generic set of tags to define these (presumably with the DICOM work group assigning a public tag)?
I think that dcm2niix (and dicm2nii, SPM) face the red queen problem: we must always update our code as the manufacturers change their DICOM implementation and our understanding of their usage evolves. Adopting DICOM simply shifts the burden of perpetual updating to other tools.
However, I also respect the view of @fedorov and his dcmqi does deliver on the promise of using DICOM directly for science. He started with the DICOM format, while many of the BIDS pipelines are wrappers for tools that do not support DICOM. Therefore, this would require a lot of investment.
This was mentioned as related in the BIDS OHBM town hall: https://github.com/ismrmrd/ismrmrd |
@arokem - i believe the scope of that file format was specifically for k-space data. |
A clear case of "one person's raw data is another person's product" |
The idea of dropping nifti (There should be one-- and preferably only one --obvious way to do it) and moving over sounds appealing to me, yes. But... that would require all(/most) common neuroimaging packages that even do not support BIDS out of the box (e.g. FSL) + the existing bidsapps to switch over to DICOM. I think hell will freeze over before that happens, while in the meantime we would create more chaos/incompatibilities... |
I think GitHub issues do not provide adequately powerful medium to discuss complex topics due to single threading etc. In DataLad, DANDI and other projects we adopted an idea of introducing "design documents" which take advantage from "code review" functionality of the GitHub by allowing for context-specific comments or recommended changes.
Hence I am submitting this PR to seek further discussion and improvements to the idea of such a BEP first.
Instructions for readers: click on 👍 or 👎 to express your opinion on overall idea
TODOs